Skip to content

Update AsyncRetryableStage + tests - #7192

Merged
dagnir merged 4 commits into
feature/master/adaptive-retries-fixesfrom
dongie/adaptive-fix-pt4-2
Jul 27, 2026
Merged

Update AsyncRetryableStage + tests#7192
dagnir merged 4 commits into
feature/master/adaptive-retries-fixesfrom
dongie/adaptive-fix-pt4-2

Conversation

@dagnir

@dagnir dagnir commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

Modifications

  • Update AsyncRetryableStage to use the new *Async methods from RetryStrategy
  • Update AdaptiveRetryRateLimitingTest to test both sync and async clients
  • Update other tests to wait on future to avoid timing issues

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
dagnir requested a review from a team as a code owner July 24, 2026 17:36
@dagnir dagnir changed the title Dongie/adaptive fix pt4 2 Update AsyncRetryableStage + tests Jul 24, 2026
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt4-2 branch from fea4acb to 164c461 Compare July 24, 2026 20:20
 - Update AsyncRetryableStage to use the new *Async methods from
   RetryStrategy
 - Update AdaptiveRetryRateLimitingTest to test both sync and async
   clients
 - Update other tests to wait on future to avoid timing issues
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt4-2 branch from 164c461 to 70480b3 Compare July 24, 2026 20:21
@dagnir
dagnir requested a review from davidh44 July 24, 2026 22:12
dagnir added 3 commits July 27, 2026 12:25
 - Remove commented sleep
 - Ensure CompletionException is unwrapped
 - Log non-zero backoff duration
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt4-2 branch from dfed4a4 to 8568020 Compare July 27, 2026 19:26
@dagnir
dagnir merged commit a5bd125 into feature/master/adaptive-retries-fixes Jul 27, 2026
3 of 4 checks passed
@dagnir
dagnir deleted the dongie/adaptive-fix-pt4-2 branch July 27, 2026 20:55
@github-actions

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants